Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046)

[mtsolo]

Thanks Han-Wen!

Cheers,
MS


http://codereview.appspot.com/4917046/diff/1/lily/align-interface.cc
File lily/align-interface.cc (right):

http://codereview.appspot.com/4917046/diff/1/lily/align-interface.cc#newcode399
lily/align-interface.cc:399: Align_interface::vertical_sort (Grob *g1,
Grob *g2)
On 2011/08/27 14:23:16, hanwenn wrote:
> this doesn't sort.

Renamed.

http://codereview.appspot.com/4917046/diff/1/lily/pure-from-neighbor-engraver.cc
File lily/pure-from-neighbor-engraver.cc (right):

http://codereview.appspot.com/4917046/diff/1/lily/pure-from-neighbor-engraver.cc#newcode4
lily/pure-from-neighbor-engraver.cc:4: Copyright (C) 1997--2011 Han-Wen
Nienhuys <address@hidden>
On 2011/08/27 14:23:16, hanwenn wrote:
> ?

Changed.

http://codereview.appspot.com/4917046/diff/1/lily/pure-from-neighbor-engraver.cc#newcode53
lily/pure-from-neighbor-engraver.cc:53: && !i.grob
()->internal_has_interface (ly_symbol2scm
("pure-from-neighbor-interface")))
On 2011/08/27 14:23:16, hanwenn wrote:
> can't you put this in acknowledge_pure_from_neighbor() so you don't
have to
> check the interface ?

I don't think this'd work - I am weeding out all
pure-from-neighbor-interface grobs from the list.  Thus, I need to nip
them in the bud before they become part of items_now_.

http://codereview.appspot.com/4917046/