Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

[pierstitus]

http://codereview.appspot.com/4974075/diff/1/lily/ledger-line-spanner.cc
File lily/ledger-line-spanner.cc (right):

http://codereview.appspot.com/4974075/diff/1/lily/ledger-line-spanner.cc#newcode362
lily/ledger-line-spanner.cc:362: ledgers.add_stencil (ledger_line);
On 2011/09/13 21:28:58, joeneeman wrote:
> Since you no longer seem to be using the brew_ledger_lines function,
please get
> rid of it.

Done. It had crossed my mind, but I forgot, thanks for noticing.

http://codereview.appspot.com/4974075/diff/1/lily/staff-symbol.cc
File lily/staff-symbol.cc (right):

http://codereview.appspot.com/4974075/diff/1/lily/staff-symbol.cc#newcode82
lily/staff-symbol.cc:82: int l = line_positions.size ();
On 2011/09/13 21:28:58, joeneeman wrote:
> Could you use a different name? l looks an awful lot like 1...

Done.

http://codereview.appspot.com/4974075/diff/1/lily/staff-symbol.cc#newcode105
lily/staff-symbol.cc:105: int l = scm_to_int (scm_length
(line_positions));
On 2011/09/13 21:28:58, joeneeman wrote:
> and again...

Done.

http://codereview.appspot.com/4974075/diff/1/lily/staff-symbol.cc#newcode117
lily/staff-symbol.cc:117: int l = Staff_symbol::line_count (me);
On 2011/09/13 21:28:58, joeneeman wrote:
> ok, this one isn't your fault, but I still think it would be good to
change it.

Done. Indeed, from here I got the l. Much better now.

http://codereview.appspot.com/4974075/