Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

[pierstitus]

On 2011/09/14 22:12:22, Neil Puttock wrote:

http://codereview.appspot.com/4974075/diff/8001/input/regression/staff-ledger-positions.ly
> File input/regression/staff-ledger-positions.ly (right):


http://codereview.appspot.com/4974075/diff/8001/input/regression/staff-ledger-positions.ly#newcode4
> input/regression/staff-ledger-positions.ly:4: by setting the
> @code{ledger-positions} property of the StaffSymbol.
> wrap around (no space at start of lines)


http://codereview.appspot.com/4974075/diff/8001/input/regression/staff-ledger-positions.ly#newcode5
> input/regression/staff-ledger-positions.ly:5: The given pattern is
repeated.
> Bracketed groups are always shown together:
> two spaces follow a full stop


http://codereview.appspot.com/4974075/diff/8001/input/regression/staff-ledger-positions.ly#newcode11
> input/regression/staff-ledger-positions.ly:11: \version "2.15.11"
> 2.15.12


http://codereview.appspot.com/4974075/diff/8001/input/regression/staff-ledger-positions.ly#newcode14
> input/regression/staff-ledger-positions.ly:14: \new Staff \relative c'
 {
> c' {


http://codereview.appspot.com/4974075/diff/8001/input/regression/staff-ledger-positions.ly#newcode15
> input/regression/staff-ledger-positions.ly:15: \override
Staff.StaffSymbol
> #'line-positions = #'( -5 -2 -1 2 5 6 )
> (-5 -2 -1 2 5 6)


http://codereview.appspot.com/4974075/diff/8001/input/regression/staff-ledger-positions.ly#newcode16
> input/regression/staff-ledger-positions.ly:16: \override
Staff.StaffSymbol
> #'ledger-positions = #'( -5 (-2 -1) 2 )
> (-5 (-2 -1) 2)


http://codereview.appspot.com/4974075/diff/8001/input/regression/staff-ledger-positions.ly#newcode18
> input/regression/staff-ledger-positions.ly:18: g, c e b' c'' e g
> g,4


http://codereview.appspot.com/4974075/diff/8001/input/regression/staff-ledger-positions.ly#newcode20
> input/regression/staff-ledger-positions.ly:20:
> remove extra newlines

> http://codereview.appspot.com/4974075/diff/8001/lily/staff-symbol.cc
> File lily/staff-symbol.cc (right):


http://codereview.appspot.com/4974075/diff/8001/lily/staff-symbol.cc#newcode105
> lily/staff-symbol.cc:105: int line_count = scm_to_int (scm_length
> (line_positions));
> scm_ilength (line_positions)


http://codereview.appspot.com/4974075/diff/8001/lily/staff-symbol.cc#newcode243
> lily/staff-symbol.cc:243: return scm_to_int (scm_length
(line_positions));
> scm_ilength (line_positions)


http://codereview.appspot.com/4974075/diff/8001/scm/define-grob-properties.scm
> File scm/define-grob-properties.scm (right):


http://codereview.appspot.com/4974075/diff/8001/scm/define-grob-properties.scm#newcode501
> scm/define-grob-properties.scm:501: (ledger-extra ,number? "Extra
distance from
> staff line to draw ledger
> ,ly:dimension?


http://codereview.appspot.com/4974075/diff/8001/scm/define-grob-properties.scm#newcode508
> scm/define-grob-properties.scm:508: of ledger lines. Bracketed groups
are always
> shown together.")
> two spaces after `lines.'

Done, typical beginner imperfections, thanks for pointing out.

http://codereview.appspot.com/4974075/