Re: GOP-PROP 13: patch management tools

[Trevor Daniels]

Graham Percival wrote Tuesday, September 20, 2011 12:09 AM

>   1. Find a different patch management tool
>   2. Find a different patch and issue management tool
>   3. Write a few python scripts to make our lives better 
>
> I favor the last option.

So do I

>    * 1-5 hours: automatically switch any Patch-review to
>      Patch-needs_work if there are any non-LGTM comments.

Hmm.  There are often comments which don't necessarily
imply disapproval (or approval for that matter).  I think we
need two keywords if this is to be automated:

LGTM - thoroughly checked and approved for pushing

LBTM (or whatever) - definitely not to be pushed, needs
further work

Then a single LBTM would automatically switch to Patch-review.

A single LGTM automatically switches to Patch-push (unless
countermanded by another comment with LBTM).

Comments without either keyword have no effect.

Trevor



-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1410 / Virus Database: 1520/3907 - Release Date: 09/19/11