Re: What's the deal with the LSR update?

[David Kastrup]

"Phil Holmes" <address@hidden> writes:

> It's a consequence of running makelsr.py on the download from the
> Lilypond Snippet Repository.  AFAI understand it, makelsr runs
> convert-ly against each file and so should update the syntax where the
> update is in convert-ly.

It isn't because it merely makes the source nicer.  The problem is that
the purpose of the LSR is not just to compile, but also to provide an
example to the user.

The original commit has been

    commit ffb5c20633459831cea21859f3423ea50060d705
    Author: David Kastrup <address@hidden>
    Date:   Tue Nov 29 15:45:15 2011 +0100

        Prefer # over $ in markups

and I think I did the changes by creating a convert-ly rule, running
update-with-convert-ly, then committing the results _without_ the
convert-ly rule because the syntax change was educational instead of
required.  As a result, the snippets have now reverted to their previous
state.

I am not saying that this is your fault: obviously I have been too
clever about this change done automatically and half-reverted.  I did
not commit the convert-ly rule since it was somewhat fishy IIRC and
while it worked, I checked the results manually.

I probably should see how I can get those changes back in a way that
sticks.  Probably they need to move through Documentation/snippets/new
for that.  I really don't have all too much of a clue here.

> After running the update, make and make doc compiled clean, so there
> shouldn't be any incorrect syntax there.

If you had made a checkout in a separate work directory, it would likely
not have compiled.  It would appear that you have uncommitted files in
your tree that are needed for compilation.

-- 
David Kastrup