Re: Final redirection of texi output (issue 5650064)

[Phil Holmes]

----- Original Message ----- 
From: <address@hidden>
To: <address@hidden>; <address@hidden>; <address@hidden>; 
<address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Monday, February 13, 2012 10:53 AM
Subject: Re: Final redirection of texi output (issue 5650064)


> LGTM
>
>
> http://codereview.appspot.com/5650064/diff/4001/scripts/build/run-and-check.sh
> File scripts/build/run-and-check.sh (right):
>
> http://codereview.appspot.com/5650064/diff/4001/scripts/build/run-and-check.sh#newcode2
> scripts/build/run-and-check.sh:2: eval $1 > $2 2>&1
> I know this has already been discussed, but I'm sorry to see no comments
> for this line.  I have no clue what it's doing, so if any problem arose
> in this part of the build system, I'd have to start reading some unix
> shell script tutorial.  That might cause maintainability problems down
> the road.
>
> Could we have a brief hint?
>
> http://codereview.appspot.com/5650064/

Actually, this specific line hasn't been discussed before it's a much 
simplified version of the previous version which was littered with comments. 
I'll add a comment as requested.

@David: think I'd prefer to stick with the shell script now, having got this 
far down the road.

--
Phil Holmes