lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Gets vertical skylines from grob stencils (issue 5626052)


From: Joe Neeman
Subject: Re: Gets vertical skylines from grob stencils (issue 5626052)
Date: Thu, 23 Feb 2012 03:11:26 -0800

On Thu, Feb 23, 2012 at 1:35 AM, address@hidden <address@hidden> wrote:
Hey all,

The newest patch set implements several of Joe's suggestions but takes a time hit because I am using the fancy skylines for Scripts.  This makes script-accidental-collision.ly look better (as well as a few other regtests) but it slows things down even more.

I think that the coding is sound, though, and it is as fast as possible given what I know how to do.  I could maybe eliminate one or two loops here or there (i.e. transforming buildings to points and back to buildings for the skyline constructor that accepts skyline pairs) but this seems like chump change. Each successive slow down comes from the skylining of a new grob, which is linear (there's tons of scripts, so tons of subtleties in the skylines).  Of course, any speed-up suggestions are welcome.

I don't see any obvious things to speed up... can you update your git branch? Then I'll profile it and take a closer look. 
Cheers,
Joe

reply via email to

[Prev in Thread] Current Thread [Next in Thread]