|
From: | Marc Hohl |
Subject: | Re: Handling of open strings in tablature (issue 5695058) |
Date: | Mon, 27 Feb 2012 11:50:51 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.27) Gecko/20120216 Thunderbird/3.1.19 |
Am 27.02.2012 10:01, schrieb address@hidden:
On 2012/02/27 00:17:05, Carl wrote:Looks like a good solution.I think I would prefer the name excludeOpenStrings toignoreOpenStrings.I think "exclude" is a better word for what is happening than "ignore"I am actually not all too happy with either choice since, if I understand it correctly, the proper name would be somewhat like dontTreatOpenStringsSpecially: they are excluded or ignored only if minimumFret (or so) is set to a value greater than 0.
Whereas dontTreatOpenStringsSpecially is probably the proper word, I'll go for excludeOpenStrings. I hope I corrected everything accordingly, because I screwed up my local branch ... :-( Regards, Marc
But then I can't think of a usefully better name. http://codereview.appspot.com/5695058/
[Prev in Thread] | Current Thread | [Next in Thread] |