lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Narrowly target warnings for multiple slurs; Issue 1967 (issue 62720


From: dak
Subject: Re: Narrowly target warnings for multiple slurs; Issue 1967 (issue 6272046)
Date: Tue, 05 Jun 2012 12:04:36 +0000


http://codereview.appspot.com/6272046/diff/9001/lily/slur-engraver.cc
File lily/slur-engraver.cc (right):

http://codereview.appspot.com/6272046/diff/9001/lily/slur-engraver.cc#newcode174
lily/slur-engraver.cc:174: bool ended = false;
Moving this out of the loop is simply wrong.  This will get a warning
only if _all_ closing events don't have an associated starting event
regardless of the spanner-id.  This needs to be done more carefully
instead of just changing the code until it stops giving warnings.

http://codereview.appspot.com/6272046/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]