lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Documentation of Kievan notation (issue 6303095)


From: janek . lilypond
Subject: Re: Documentation of Kievan notation (issue 6303095)
Date: Mon, 18 Jun 2012 07:41:55 +0000

LGTM, minor style issues.


http://codereview.appspot.com/6303095/diff/1/Documentation/music-glossary.tely
File Documentation/music-glossary.tely (right):

http://codereview.appspot.com/6303095/diff/1/Documentation/music-glossary.tely#newcode4539
Documentation/music-glossary.tely:4539: jurisdictions of Orthodoxy and
Byzantine-rite Catholicism. It is
There should be two spaces after period that closes sentence (here and
in some places in the second file).

http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely
File Documentation/notation/ancient.itely (right):

http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely#newcode2464
Documentation/notation/ancient.itely:2464: There is only one clef used
in Kievan notation (the Tse-fa-ut Clef). It is used to indicate the
position of @code{c}, as in the following example:
Please split this line.

http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely#newcode2530
Documentation/notation/ancient.itely:2530: \markup {
Should this be included as a lilypond example?

http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely#newcode2562
Documentation/notation/ancient.itely:2562:
@lilypond[quote,ragged-right,staffsize=24]
similar to above - i don't think people should use it this way? (i.e.
via \musicglyph)

http://codereview.appspot.com/6303095/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]