[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Documentation of Kievan notation (issue 6303095)
From: |
aleksandr . andreev |
Subject: |
Re: Documentation of Kievan notation (issue 6303095) |
Date: |
Tue, 19 Jun 2012 00:07:13 +0000 |
Updated patch based on comments by Janek and Trevor.
http://codereview.appspot.com/6303095/diff/1/Documentation/music-glossary.tely
File Documentation/music-glossary.tely (right):
http://codereview.appspot.com/6303095/diff/1/Documentation/music-glossary.tely#newcode4539
Documentation/music-glossary.tely:4539: jurisdictions of Orthodoxy and
Byzantine-rite Catholicism. It is
On 2012/06/18 07:41:55, janek wrote:
There should be two spaces after period that closes sentence (here and
in some
places in the second file).
Done.
http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely
File Documentation/notation/ancient.itely (right):
http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely#newcode41
Documentation/notation/ancient.itely:41: Gregorian notation.
On 2012/06/18 08:06:15, Trevor Daniels wrote:
"... contexts for these styles." maybe.
Done.
http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely#newcode2431
Documentation/notation/ancient.itely:2431: as the following excerpt
demonstrates:
On 2012/06/18 08:06:15, Trevor Daniels wrote:
Stop after the comma, and change that to a colon.
Done.
http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely#newcode2464
Documentation/notation/ancient.itely:2464: There is only one clef used
in Kievan notation (the Tse-fa-ut Clef). It is used to indicate the
position of @code{c}, as in the following example:
On 2012/06/18 08:06:15, Trevor Daniels wrote:
Stop after the comma, and change that to a colon.
Done.
http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely#newcode2537
Documentation/notation/ancient.itely:2537: @end lilypond
On 2012/06/18 08:06:15, Trevor Daniels wrote:
Rather than displaying the glyphs (which already appear in Appendix 8
and should
be referenced there) it would be better to move the following para
about
accidental style before this one and then show the use of accidentals
in context
in a bar of music.
Done.
http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely#newcode2566
Documentation/notation/ancient.itely:2566: @end lilypond
On 2012/06/18 08:06:15, Trevor Daniels wrote:
Could this example include a bar of music to show how the two fit
together?
Maybe the last two examples should be merged? I'm not sure the Kievan
bar line deserves a subsection all to itself. What do you think?
http://codereview.appspot.com/6303095/
- Documentation of Kievan notation (issue 6303095), aleksandr . andreev, 2012/06/17
- Re: Documentation of Kievan notation (issue 6303095), janek . lilypond, 2012/06/18
- Re: Documentation of Kievan notation (issue 6303095), tdanielsmusic, 2012/06/18
- Re: Documentation of Kievan notation (issue 6303095),
aleksandr . andreev <=
- Re: Documentation of Kievan notation (issue 6303095), janek . lilypond, 2012/06/19
- Re: Documentation of Kievan notation (issue 6303095), tdanielsmusic, 2012/06/19
- Re: Documentation of Kievan notation (issue 6303095), graham, 2012/06/19
- Re: Documentation of Kievan notation (issue 6303095), aleksandr . andreev, 2012/06/19
- Re: Documentation of Kievan notation (issue 6303095), tdanielsmusic, 2012/06/20
- Re: Documentation of Kievan notation (issue 6303095), aleksandr . andreev, 2012/06/22
- Re: Documentation of Kievan notation (issue 6303095), janek . lilypond, 2012/06/23
- Re: Documentation of Kievan notation (issue 6303095), aleksandr . andreev, 2012/06/23