Re: [XY]-core-extent and general_alignment (issue 2613) (issue 6308093)

[janek . lilypond]

Hi,

After rereading the code i see that you are totally right!  I don't know
why i wanted to use dim_cache so much.  It's scrapped now.

Joe, thanks to your suggestion it is now possible to read extent from
any property, including user-defined ones!

many thanks,
Janek


http://codereview.appspot.com/6308093/diff/1/lily/self-alignment-interface.cc
File lily/self-alignment-interface.cc (right):

http://codereview.appspot.com/6308093/diff/1/lily/self-alignment-interface.cc#newcode206
lily/self-alignment-interface.cc:206: grob_alignment = scm_to_double
(scm_cdr (grob_alignment_property));
On 2012/06/20 09:45:26, joeneeman wrote:
> Use robust_scm2double

Done.

http://codereview.appspot.com/6308093/diff/1/lily/self-alignment-interface.cc#newcode221
lily/self-alignment-interface.cc:221: : me->core_extent (me, a);
On 2012/06/20 09:45:26, joeneeman wrote:
> What about:
> if (which_grob_extent == ly_symbol2scm ("extent"))
>    grob_extent = me->extent (me, a);
> else
>    grob_extent = ly_scm2interval(me->get_property (which_grob_extent);

> Then you can get rid of all the core-extent-related caching code.

Done. (in a bit different way)

http://codereview.appspot.com/6308093/