Re: Treat accidentals parentheses as cautionary (issue 6310065)

[julien . rioux]

Reviewers: MikeSol, Graham Percival,

Message:
On 2012/06/22 08:20:56, Graham Percival wrote:
> LGTM, although I'd personally have prepended "musicxml2ly:" to the
beginning of
> the patch subject line.  That makes it much more obvious when skimming
the git
> history (or just available patches to review).

I just did a git am using his patch, but I'll amend the commit before
pushing. Do we need some license statement from Rodolfo?

--
Julien

Description:
Treat accidentals parentheses as cautionary

Patch from Rodolfo Zitellini

Please review this at http://codereview.appspot.com/6310065/

Affected files:
  M scripts/musicxml2ly.py


Index: scripts/musicxml2ly.py
diff --git a/scripts/musicxml2ly.py b/scripts/musicxml2ly.py
index  
69125dc9db6cdccbb52d47c19296c6191974fa4e..cd76ebeca3e14d073aa7c24d6c0098c040d9c1c9  
100644
--- a/scripts/musicxml2ly.py
+++ b/scripts/musicxml2ly.py
@@ -1784,8 +1784,12 @@ def musicxml_note_to_lily_main_event (n):

         acc = n.get_maybe_exist_named_child ('accidental')
         if acc:
-            # let's not force accs everywhere.
-            event.cautionary = acc.cautionary
+            # AccidentalCautionary in lily has parentheses
+            # so treat accidental explicitly in parentheses as cautionary
+            if hasattr(acc, 'parentheses') and acc.parentheses == "yes":
+                event.cautionary = True
+            else:
+                event.cautionary = acc.cautionary
             # TODO: Handle editorial accidentals
             # TODO: Handle the level-display setting for displaying  
brackets/parentheses