Re: which-page (issue 6352049)

[dak]

A feature should be documented, or it will not be discoverable.

If feasible, a regtest should be added in input/regression.  Whether
this is possible for essentially multi-page features, I don't know, so
it is possible that this particular feature does not really lend itself
to a regtest.


http://codereview.appspot.com/6352049/diff/1/ly/titling-init.ly
File ly/titling-init.ly (right):

http://codereview.appspot.com/6352049/diff/1/ly/titling-init.ly#newcode104
ly/titling-init.ly:104: #(define ((which-page nmbr) layout props arg)
"which-page" seems like a less than optimal name for the intended use
patterns:

\on-the-fly #(which-page 3) ...

reads less natural than

\on-the-fly #(on-page 3) ...

or

\on-the-fly #(at-page 3) ...

http://codereview.appspot.com/6352049/diff/1/ly/titling-init.ly#newcode105
ly/titling-init.ly:105: (if (= (chain-assoc-get 'page:page-number props
0) nmbr)
The functions below seem to prefer "-1" for something coming without
page number.  Perhaps it would make sense to conform with that kind of
usage.

http://codereview.appspot.com/6352049/