[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: prevent collision of ligatures and next note (issue 6740046)
From: |
Benkő Pál |
Subject: |
Re: prevent collision of ligatures and next note (issue 6740046) |
Date: |
Wed, 24 Oct 2012 15:11:21 +0200 |
>> > Ah, so this is a by-the-way fix. Can it be in a separate commit, please?
>
>> it is; I meant to note it but forgot, sorry. is there interest in pushing
>> such
>> multi-commit patches to some dev branch?
>
> If there is, people should ask. Substructuring an issue into several
> logical commits is good style and makes things easier afterwards, but
> only few people will actively prefer reviewing changes in a branch over
> using Rietveld, so you can save yourself the trouble of creating a
> public branch unless someone asks for it.
I meant opening a Rietveld issue with all changes and an
announcement of a dev branch with several commits.
> Just make sure that every commit leaves the tree in compilable state.
of course. I've verified that the pass-by-reference commit didn't
change the regtests.