[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)
From: |
dak |
Subject: |
Re: Issue 2445: Add measure counter to LilyPond (issue 6730044) |
Date: |
Wed, 31 Oct 2012 11:47:38 +0000 |
On 2012/10/31 11:41:19, david.nalesnik wrote:
David,
I don't mind making the changes, but I'm running into some problems.
I used git
pull -r before making a patch set and uploading to rietveld, but
looking over
the patch set there I see that other changes have found their way
in--including
your check-grob-path function.
check-grob-path is in current master. Rietveld is not all too clever
about changing material underneath a patch, but you don't really need a
separate review for those changes, as they are just a consequence of
running convert-ly, and your patch already passed countdown.
If you are worried, you can send me the patch and I'll do what is
needed.
https://codereview.appspot.com/6730044/
- Re: Issue 2445: Add measure counter to LilyPond (issue 6730044), (continued)
- Re: Issue 2445: Add measure counter to LilyPond (issue 6730044), janek . lilypond, 2012/10/24
- Re: Issue 2445: Add measure counter to LilyPond (issue 6730044), david . nalesnik, 2012/10/24
- Re: Issue 2445: Add measure counter to LilyPond (issue 6730044), janek . lilypond, 2012/10/24
- Re: Issue 2445: Add measure counter to LilyPond (issue 6730044), pkx166h, 2012/10/24
- Re: Issue 2445: Add measure counter to LilyPond (issue 6730044), pkx166h, 2012/10/24
- Re: Issue 2445: Add measure counter to LilyPond (issue 6730044), david . nalesnik, 2012/10/25
- Re: Issue 2445: Add measure counter to LilyPond (issue 6730044), dak, 2012/10/31
- Re: Issue 2445: Add measure counter to LilyPond (issue 6730044), dak, 2012/10/31
- Re: Issue 2445: Add measure counter to LilyPond (issue 6730044), david . nalesnik, 2012/10/31
- Re: Issue 2445: Add measure counter to LilyPond (issue 6730044),
dak <=
- Re: Issue 2445: Add measure counter to LilyPond (issue 6730044), david . nalesnik, 2012/10/31
- Re: Issue 2445: Add measure counter to LilyPond (issue 6730044), dak, 2012/10/31
- Re: Issue 2445: Add measure counter to LilyPond (issue 6730044), dak, 2012/10/31