Fix for issue 2967 [was Re: Your Patches]

[Trevor Daniels]

Francisco Vila wrote Sunday, November 25, 2012 5:15 PM

> 2012/11/25 Trevor Daniels <address@hidden>:
> 
>>> --snip--
>>> WARNING: Unable to find node 'Creating titles' in book notation.
>>> *** Undefined node `Single staff' in @ref (in
>>> out-www/learning/fundamental.texi l. 3171)
>>> Max error number exceeded
>>> --snip--
>>>
>>> unfortunately the build scripts don't say *which* log to look at (i.e.
>>> there are learning.bigtexi.log files in all the languages - most are 0
>>> bytes).
>>>
>>> But it does stop make doc.
>>
>> Thanks James.  I think this is because Documentation/nl/learning does
>> not contain the templates.itely file, so make doc defaults to using
>> that file from Documentation/learning, which has different node
>> names after this patch is applied.
> 
>> All the language directories contain templates.itely except nl, so
>> the fix is probably to copy this file (before this patch) into nl.
> 
> I think you're right. Seems strange why a fix for a problem caused by
> a patch that does not touch anything in nl/ , is to copy an old file
> with different node names, but it's true.

I've uploaded a new patch-set for 
http://codereview.appspot.com/6852077
which adds the missing .itely files to Documentation/nl/learning and
Documentation/hu/learning.  Make doc should now complete
successfully, cross fingers.

James: as this is uncertain and I'm not really in a position to run
a full make doc at present would you be able to check this patch
before it gets to a countdown?  I'll send you a format-patch
of this change separately as it's quite large.  Thanks.

Trevor