[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Reformat some files to let emacs do its work correctly. (issue 98630
From: |
marc |
Subject: |
Re: Reformat some files to let emacs do its work correctly. (issue 9863047) |
Date: |
Tue, 04 Jun 2013 08:57:00 +0000 |
Reviewers: Keith,
Message:
On 2013/06/04 06:33:11, Keith wrote:
LGTM
It makes sense to let humans look at the hand-made changes, and then
just run
fixscm.sh and let `make check` test that.
Ok. Since fixscm.sh was applied once without breaking the build process,
it is rather unlikely to get unwanted surprises ...
https://codereview.appspot.com/9863047/diff/1/scm/define-grob-interfaces.scm
File scm/define-grob-interfaces.scm (right):
https://codereview.appspot.com/9863047/diff/1/scm/define-grob-interfaces.scm#newcode76
scm/define-grob-interfaces.scm:76: '(delta-position
Lists that fit all on one line are good on one line.
These changes are okay, but I suggest reversing them so the code
history is
easier to follow.
I for myself like the new formatting; it's closer to the
list of properties at the end of the c++ engraver files.
Description:
Reformat some files to let emacs do its work correctly.
Please review this at https://codereview.appspot.com/9863047/
Affected files:
M scm/chord-entry.scm
M scm/define-context-properties.scm
M scm/define-event-classes.scm
M scm/define-grob-interfaces.scm
M scm/define-music-types.scm
M scm/define-woodwind-diagrams.scm
M scm/display-woodwind-diagrams.scm
M scm/document-markup.scm
M scm/flag-styles.scm
M scm/fret-diagrams.scm
M scm/harp-pedals.scm
M scm/layout-slur.scm
M scm/lily-library.scm
M scm/lily.scm
M scm/music-functions.scm
M scm/scheme-engravers.scm
M scm/skyline.scm
M scm/song.scm
M scm/stencil.scm
- Reformat some files to let emacs do its work correctly. (issue 9863047), k-ohara5a5a, 2013/06/04
- Re: Reformat some files to let emacs do its work correctly. (issue 9863047), k-ohara5a5a, 2013/06/04
- Re: Reformat some files to let emacs do its work correctly. (issue 9863047), k-ohara5a5a, 2013/06/04
- Re: Reformat some files to let emacs do its work correctly. (issue 9863047), k-ohara5a5a, 2013/06/04
- Re: Reformat some files to let emacs do its work correctly. (issue 9863047),
marc <=
- Re: Reformat some files to let emacs do its work correctly. (issue 9863047), dak, 2013/06/06
- Re: Reformat some files to let emacs do its work correctly. (issue 9863047), dak, 2013/06/06
- Re: Reformat some files to let emacs do its work correctly. (issue 9863047), dak, 2013/06/06
- Re: Reformat some files to let emacs do its work correctly. (issue 9863047), marc, 2013/06/07