lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Reformat some files to let emacs do its work correctly. (issue 98630


From: James
Subject: Re: Reformat some files to let emacs do its work correctly. (issue 9863047)
Date: Fri, 7 Jun 2013 13:53:00 +0100




On 7 June 2013 11:07, Marc Hohl <address@hidden> wrote:
Am 07.06.2013 09:07, schrieb Keith OHara:
On Thu, 06 Jun 2013 23:04:29 -0700, <address@hidden> wrote:

I think I'll draw a patch that corrects the minor faults; ideally,
running
fixscm again should lead in no changes at all.


That makes good sense.

It is hard to spot unwanted changes among the good changes from running
the script.


time-signature-settings.scm, maybe some newlines

@@ -312,24 +312,24 @@ a fresh copy of the list-head is made."
           (den (car revargs))
           (nums (reverse (cdr revargs))))
      (make-override-markup '(baseline-skip . 0)
-      (make-number-markup
-        (make-left-column-markup (list
-          (make-center-column-markup (list
-            (make-line-markup (insert-markups nums "+"))
-            den))))))))
+                          (make-number-markup
+                           (make-left-column-markup (list
+
(make-center-column-markup (list
+
(make-line-markup (insert-markups nums "+"))
+
den))))))))

done.

define-markup-commands.scm, maybe some ;;

3037 (define-public (horizontal-slash-interval num forward
number-interval mag)
3038   (if forward
3039       (cond ;((= num 6) (interval-widen number-interval (* mag 0.5)))
3040                                         ;((= num 5) (interval-widen
number-interval (* mag 0.5)))
...

done. Thanks!

BTW, I raised a new issue for this:

http://code.google.com/p/lilypond/issues/detail?id=3404

and uploaded a patch:

http://codereview.appspot.com/9964049

Regards,

Marc






_______________________________________________
lilypond-devel mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/lilypond-devel


For some reason it wasn't being picked up by Patchy, so I had to 'turn-it-off-and-turn-it-on-again' so that Patch-New was detected for testing.

In case you wondered.

james

reply via email to

[Prev in Thread] Current Thread [Next in Thread]