[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Simplified version of Trevor Daniels' SATB framework. (issue 3872004
From: |
tdanielsmusic |
Subject: |
Re: Simplified version of Trevor Daniels' SATB framework. (issue 38720045) |
Date: |
Tue, 17 Dec 2013 23:36:03 +0000 |
I've now got a clean compile of a simple
four-staff SATB score, with the changes
shown.
More tests to follow, probably tomorrow ...
Trevor
https://codereview.appspot.com/38720045/diff/1/ly/satb.ly
File ly/satb.ly (right):
https://codereview.appspot.com/38720045/diff/1/ly/satb.ly#newcode78
ly/satb.ly:78: (let ((above (if (pair? optionals) (car optionals))))
This should be
(let ((above (if (pair? optionals) (car optionals) #f)))
to avoid error messages
https://codereview.appspot.com/38720045/diff/1/ly/satb.ly#newcode98
ly/satb.ly:98: \voiceOne
This should be \oneVoice
https://codereview.appspot.com/38720045/diff/1/ly/satb.ly#newcode103
ly/satb.ly:103: #(lyrics-if-defined ,(sym name "Lyrics") ,name)
This should be
#(lyrics-if-defined ,(sym name "Lyrics"))
otherwise the lyrics go above the staff.
https://codereview.appspot.com/38720045/
- Re: Simplified version of Trevor Daniels' SATB framework. (issue 38720045),
tdanielsmusic <=
Re: Simplified version of Trevor Daniels' SATB framework. (issue 38720045), dschudy, 2013/12/19