[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045
|
From: |
k-ohara5a5a |
|
Subject: |
Re: note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045) |
|
Date: |
Mon, 30 Dec 2013 00:05:07 +0000 |
On 2013/12/29 22:58:32, janek wrote:
Do you mean that you won't add a regtest or won't use big staffsize?
I won't add a regression test. Several tests already change in response
to this change in code.
Some thoughts on the space around the \mark are below:
https://codereview.appspot.com/36830045/diff/120001/lily/note-spacing.cc
File lily/note-spacing.cc (right):
https://codereview.appspot.com/36830045/diff/120001/lily/note-spacing.cc#newcode95
lily/note-spacing.cc:95: {
Here is where I kept the extra space for a 'non-musical' column such as
that holding a \mark, for a naturally-spaced line.
https://codereview.appspot.com/36830045/diff/120001/lily/spacing-spanner.cc
File lily/spacing-spanner.cc (right):
https://codereview.appspot.com/36830045/diff/120001/lily/spacing-spanner.cc#newcode370
lily/spacing-spanner.cc:370: if (Paper_column::is_musical (right_col))
Probably here is where the old code was making the extra space around a
'non-musical' column be extra-compressible, though I'm not sure.
https://codereview.appspot.com/36830045/