lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Check for Note_column interface before using grob. (issue 141190043


From: dak
Subject: Re: Check for Note_column interface before using grob. (issue 141190043 by address@hidden)
Date: Sun, 07 Sep 2014 06:58:30 +0000

On 2014/09/07 06:23:08, Keith wrote:
LGTM

https://codereview.appspot.com/141190043/diff/1/lily/rest-collision.cc
File lily/rest-collision.cc (right):


https://codereview.appspot.com/141190043/diff/1/lily/rest-collision.cc#newcode111
lily/rest-collision.cc:111: if (Note_column::has_interface(e))
We'll run this through the 'fixcc.py' code formatter at some point,
keeping
things consistent with the (admittedly odd) GNU style.

It's better to follow the style right away when feasible since it makes
for nicer histories when calling "git blame" and its ilk.

https://codereview.appspot.com/141190043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]