Re: Web: revise navigation bars with CSS gradients (issue 193140043 by address@hidden)

[Paul Morris]

pkx166h wrote
> Fails to apply to current master.

Hmmm, I'm not sure what went wrong.  It succeeded previously and then I just
added the images without changing any code.  I rebased on origin/master
before submitting the patch set (#3) and everything seemed to be in place
(using gitk to check).  But I see that a new commit has now been added to
origin/master, so maybe that was the problem?  So I've submitted another
patch set (#4) after rebasing on the current origin/master.  

I'm assuming that the reason my patch fails to apply to current master has
something to do with git and the need to rebase on origin/master, although I
suppose it could be something to do with adding the images to the patch? 
(Please bear with me as I learn git and the LilyPond contributor
procedures.)


pkx166h wrote
> Please also make sure that when you make a new patch set you change the
> tracker label to patch-new so that it gets tested automatically.
> 
> https://codereview.appspot.com/193140043/

Sorry about that.  I don't have sufficient privileges to change labels
myself, and I forgot that it needed to be done.  I should have heeded the
following message, but I missed its significance.

  WARNING: could not change issue labels;
  please email lilypond-devel with the issue number: 4258

I wish it had said:

  WARNING: could not change issue label to "patch-new",
  so the patch set will not be tested automatically,
  please email lilypond-devel with the issue number (4258),
  and request that the issue label be changed to "patch-new"


In any case, can someone please change the issue label for issue 4258 to
"patch-new"?  

https://code.google.com/p/lilypond/issues/detail?id=4258

Thanks,
-Paul



--
View this message in context: 
http://lilypond.1069038.n5.nabble.com/Web-revise-navigation-bars-with-CSS-gradients-issue-193140043-by-paulwmorris-gmail-com-tp170477p170570.html
Sent from the Dev mailing list archive at Nabble.com.