Re: git-cl upload has stopped working?

[David Kastrup]

James Lowe <address@hidden> writes:

> On 28/05/15 12:35, Dan Eble wrote:
>> On May 27, 2015, at 16:17 , David Kastrup <address@hidden> wrote:
>>>
>>> So what I did was pressed "Create Issue" on codereview.appspot.com which
>>> tells you to use update.py and provides a download for it.  So I
>>> downloaded it, overwrote the version in the git-cl directory (which does
>>> not know about oauth2) with it, edited the --oauth2 option to default to
>>> True (since I did not figure out how upload.py is getting called by
>>> git-cl).
>> 
>> --- git-cl.old  2015-05-28 07:17:39.466031501 -0400
>> +++ git-cl      2015-05-28 07:32:45.550061049 -0400
>> @@ -648,6 +648,7 @@
>>    subject = desc.splitlines()[0]
>>    upload_args.extend(['--title', subject])
>>    upload_args.extend(['--message', desc])
>> +  upload_args.append('--oauth2')
>>    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
>>    if not cl.GetRietveldIssue():
>>      cl.SetRietveldIssue(issue)
>> 
>> — 
>> Dan
>> 
>
> Is this anything we can push to the git-cl repo?

Only in connection with replacing its whole upload.py with the current
one from codereview.appspot.com.  Which gives us a change of the
authentication files in use I think and will only salvage git-cl -n.
Which is probably still better than not having any part of git-cl work,
but by no means a complete job.

-- 
David Kastrup