|
| From: | thomasmorley65 |
| Subject: | Create \= command for setting spanner-id (issue 268050045 by address@hidden) |
| Date: | Sun, 04 Oct 2015 00:45:35 +0000 |
LGTM
Some nitpicks:
https://codereview.appspot.com/268050045/diff/1/Documentation/notation/expressive.itely
File Documentation/notation/expressive.itely (right):
https://codereview.appspot.com/268050045/diff/1/Documentation/notation/expressive.itely#newcode724
Documentation/notation/expressive.itely:724: them with @code{\=}
followed by an identifying number or string.
If we explain the needed label may be number or string, why not give an
example for each in the code below.
https://codereview.appspot.com/268050045/diff/1/Documentation/notation/expressive.itely#newcode728
Documentation/notation/expressive.itely:728: <c~ f\=1( g\=2( >2 <c e\=1)
a\=2) >
Am I correct this example does only work with the fix for issue 4625
applied?
https://codereview.appspot.com/268050045/
| [Prev in Thread] | Current Thread | [Next in Thread] |