Re: Verifying issues

[Phil Holmes]

----- Original Message ----- 
From: "Simon Albrecht" <address@hidden>
To: "ly-devel" <address@hidden>
Sent: Wednesday, March 02, 2016 10:52 PM
Subject: Verifying issues


> Hello,
>
> I noticed that there have been many ‘Issues to verify’ around, so I 
> started to catch up with these. Now the question is: Shouldn’t we only 
> mark issues as verified, when the change is already included in an 
> official release?
> For curiosity, following the CG instruction I took the committish from 
> <https://sourceforge.net/p/testlilyissues/issues/4754/> – claimed to be 
> ‘Fixed_2_19_38’ – and fed it into <http://philholmes.net/lilypond/git/>, 
> and it worked. So according to the instruction, I should mark the issue 
> verified, although the change is not contained in the most recent release, 
> 2.19.37.
> What do you think?
>
> Best, Simon

If you read _all_ the text in the CG concerning issues to verify, it says:

"do not verify any Issues where the claimed fixed build is not yet released"

so you should not even look in git for an issue marked "Fixed_2_19_38" since 
it is not in a released build.  The Git check is solely to check that 
patches claimed to be in a release build actually are.

--
Phil Holmes