Re: Working on issue 665, how to proceed?

[Thomas Morley]

Am So., 17. Nov. 2019 um 18:13 Uhr schrieb <address@hidden>:
>
> > -----Oorspronkelijk bericht-----
> > Van: David Kastrup <address@hidden>
> > > I did use a lot of define-method, as it is easy this way to be type
> > > save.
> >
> > I don't think the cost justifies the effort here.  Scheme is not intended 
> > as a
> > "type safe" language.

What disturbs me are things like:

(define-method (->number (value <boolean>))
    (cond (value 1 (else 0)))
)

(define-method (->number (value <number>))
    value
)

(define-method (->number (value <string>))
    (string->number value)
)

I'd always sort the arg in procedure's body, like

(define (->number arg)
  (cond ((number? arg) arg)
          ((boolean? arg) (if arg 1 0))
          ((string? arg) (string->number arg))
          (else #f)))


> In the mean time I start working with all of your suggestions, and after that 
> I go extend the conversion until the entire music part is converted.
> I will continue to push to my own git repository, until I think the 
> conversion script is ready for a serious proposal.

What misses is something like a test-suite.
Once the code is mature enough to be implemented into core-lilypond,
we would need to have some sort of regression-tests.
Currently I've no clue how we could do so, though,

> And until that I will continue to ask the community for feedback.
>
> At the same time I encourage you to use what I have written so far, and 
> appreciate your feedback

You're welcome ;)


Cheers,
  Harm