Re: Integration of Guilev2 branches into master

[David Kastrup]

Han-Wen Nienhuys <address@hidden> writes:

> On Fri, Feb 7, 2020 at 6:54 PM David Kastrup <address@hidden> wrote:
>
>> I propose that I am going to pick up the pieces of
>> not-actually-formally-reviewed patches making up the bulk of them and
>> put them, Guilev2-guarded (so that they don't affect Guilev1
>> compilations) into staging->master without going through the formal
>> processes.
>>
>> The reason to do that is that the current state already likely wasted
>> considerable time of Han-Wen by finding solutions for problems that were
>> already previously turned into non-showstoppers although not necessarily
>> in the cleanest manner.  But it would seem that even if part of them is
>> likely to eventually be superseded, giving Han-Wen a better starting
>> place would make him work and plan more effectively.
>>
>
> Thanks, David!
>
> Can you mark the commits with some prefix ("GUILE2: blah") so they stand
> out?

Ok.  One warning: you will likely most be affected where commits have
drawbacks.  For example, I just glanced over the following commit (id is
not in repository since I just rebased):

commit 331bfc761837675fa8075a51b1fbceccfd82380b
Author: David Kastrup <address@hidden>
Date:   Thu Sep 18 14:56:54 2014 +0200

    Initialize locale in GUILEv2
    
    This is necessary to be able to load ly/text-replacements.ly and, of 
course, user files
    using utf-8.  Requires an utf-8 locale.

diff --git a/ly/init.ly b/ly/init.ly
index 979f9778bb..610775854a 100644
--- a/ly/init.ly
+++ b/ly/init.ly
@@ -7,7 +7,9 @@
 \version "2.19.22"
 
 #(if (guile-v2)
-  (use-modules (ice-9 curried-definitions)))
+  (begin
+   (use-modules (ice-9 curried-definitions))
+   (setlocale LC_ALL "")))
 
 #(session-initialize
   (lambda ()


So it can end up a mixed blessing with regard to work you already
started or possibly even committed.  Overall, I would suppose that the
changes should be a step forward.

-- 
David Kastrup
My replies have a tendency to cause friction.  To help mitigating
damage, feel free to forward problematic posts to me adding a subject
like "timeout 1d" (for a suggested timeout of 1 day) or "offensive".