|
From: | pkx166h |
Subject: | Re: Address output-distance problems: (issue 563730043 by address@hidden) |
Date: | Thu, 12 Mar 2020 12:15:54 +0000 |
User-agent: | Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 12/03/2020 10:32, Han-Wen Nienhuys wrote:
On Thu, Mar 12, 2020 at 10:37 AM <address@hidden> wrote:Hello What exactly am I supposed to be testing? With or without make check? I am struggling with all this 'back and forth' and with patches getting created and tested by different people (worksforme, doesn't work for me etc.).This is exactly why I have been advocating tests based on docker containers, so we have a common understanding of when something passes tests and when not.
Actually, with all due respect, this is neither here nor there is it?I had said that tests for this (or other issues) had failed make check and was told - one case by yourself - that this was expected and not to run the make check. So this is why I put '...make test-baseline..' in my 'passes ...' note in the tracker. I think Jonas queried it once (which led to me learning how to make my set of tests more robust for build file patches).
I don't hava a problem following instructions, and you developers make the final decisisons, so I have to assume there is a good reason I am told to ignore a test.
Would docker give us this 'proverbial canary' or would it turn into 'worksforme' when someone tried to build their own version of LPĀ on a vanilla base of Linux ;)
James
[Prev in Thread] | Current Thread | [Next in Thread] |