RE: [Ltib] new LTIB platform diffs for submission

[Kevin Wells]

Hi Stuart,

Thanks again for your help. I've updated the main.lkc file with your 
recommendations.
I'll also change the u-boot spec and patch to be CPU specific instead of board 
specific - to work across multiple board configurations.

Thanks,
Kevin Wells
NXP


> -----Original Message-----
> Sent: Wednesday, January 14, 2009 12:51 AM
> Subject: Re: [Ltib] new LTIB platform diffs for submission
> 
> Hi Kevin,
> 
> I had a quick scan and it looks okay to me.  Here are a few comments:
> 
> * If these versions of u-boot/kernel are specific to this platform, you
> could put your u-boot/kernel spec files into config/platform/phy3250.
> The advantage of this is that your BSP abstractions becomes completely
> self-contained.  If however you may use these spec files for other
> platforms, then leave them under dist/lfs-5.1/...
> 
> * You have set CFGHOST as 'arm-linux-gnu'.  Although this is correct, it
> may be better to leave it as just 'arm-linux'.  The reason is that they
> could be (I can't remember) some packages or spec file script-age that
> assumes 2 tokens separated by a '-', I can't recall.
> 
> * In some cases you have assigned a 'default ""' for a string.  You can
> if you want removed these as the default (if not specified) is empty.
> However leaving it doesn't cause any problems.
> 
> Regards, Stuart
> 
> On Tue, 2009-01-13 at 20:12 +0100, Kevin Wells wrote:
> >
> >
> > I've got LTIB platform additions ready for submission. I didn't need
> > to make any changes to the existing files. Only new platform files and
> > 2 new spec files were added. The CVS diffs and new files are attached.
> > The kernel, busybox, and LTIB config files are not attached. Sorry
> > about attaching too much, but I'd rather be safe than checking in
> > something I'm probably not supposed to.
> >
> >
> >
> 
> >