[lwip-devel] [task #7142] Sanity check user-configurable values

[Jonathan Larmour]

Follow-up Comment #8, task #7142 (project lwip):

Thanks for this. Some comments on the patch:

* if (MEMP_NUM_NETCONN < (all the PCBs)

This is the opposite sense from what I had been thinking of. It's possible to
configure fewer netconns than PCBs (e.g. if using the raw API, or raw API
subsystems like SNMP too), but it would be pointless to configure more. Not
incorrect, but pointless possibly revealing a lack of understanding of the
config dependencies.

*  if (MEMP_NUM_NETBUF < (PBUF_POOL_SIZE+MEMP_NUM_PBUF))

Ditto here. It's possible to have fewer netbufs, but pointless to have more.

The rest looks good, and this makes it easy to add more, thanks!


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7142>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/