[Monotone-devel] Re: [Monotone-commits-diffs] Revision eeef5ff823a54c2a678d40da6f658881679b809b

[Eric Anderson]

Richard Levitte writes:
 > Eric Anderson writes: 
 > > Richard Levitte - VMS Whacker writes:
 > >  > Can I request a name change to "guess_binary_file"? 
 > > 
 > > Perhaps guess_binary_from_filename (makes it clear that the function
 > > doesn't take a LUA "file" object)?  I can't make the change, but
 > > someone else should be able to.
 > 
 > Hmm, it seems we come from different schools of naming.  My perspective is 
 > that a function name should describe what it does.  This function check the 
 > file contents to see if it's binary.  It does not check if the file name 
 > itself is binary or not.  Therefore I think it should should say (with it's 
 > name) that it checks for binary file contents.  Maybe 
 > "guess_binary_file_contents" then?  Either way, "guess_binary_filename" 
 > feels confusing to me... 

Naming conventions are tricky, guess_binary_file_contents seems good to me.
        -Eric