Re: [Monotone-devel] Interesting bug in French locale :-)

[Benoît Dejean]

Le vendredi 09 septembre 2005 à 08:35 +0200, Richard Levitte - VMS
Whacker a écrit :

> 
> Now, I'm trying to figure out what's happening, exactly, so I can fix
> the problem.  To begin with, I think I need a pointer to where '_' is
> defined.  It's incredibly difficult to find among all other
> underscores :-)...

it's

const char * gettext(const char *);

and i don't think you'll find anything interesting in its internal.
NB : With utf-8 str.size() >= length(utf8(str));

        Btw, the code assumes that each ticker as a unique name
(std::map<std::string,ticker *> tickers;). With wrong/incomplete
translations or charset issues (here you get "octets ?" twice), I() is
broken. It seems harmful to use i18n strings that way. The good news is
that tickers std::set's features are used only with I() to ensure that
the ticker has been registred (or has not already been).
        So just switch to std::vector<ticker*> and check for value, not
value->name. The map was a hack because somebody was too lazy too write
an operator< / == for ticker. Easy fix i think.

-- 
Benoît Dejean <address@hidden>

signature.asc
Description: This is a digitally signed message part