Re: [Monotone-devel] Re: [Monotone-commits-diffs] Revision 0ba2c2c0f5daef25ca705f4280ecf3ea1ebe39bd

[Richard Levitte - VMS Whacker]

In message <address@hidden> on Wed, 14 Sep 2005 22:22:42 -0700, Nathaniel Smith 
<address@hidden> said:

njs> On Thu, Sep 15, 2005 at 06:58:32AM +0200, Richard Levitte - VMS Whacker 
wrote:
njs> > Hmm, does anyone mind if I add yet another argument to
njs> > hook_note_commit and hook_note_netsync_revision_received,
njs> > containing the parents of the committed/received revision?  The
njs> > reason would be to make it really easy to generate diffs...
njs> 
njs> I'm not sure how good an idea it is to generate diffs from within
njs> the commit/netsync hooks... the simultaneous db access is likely
njs> to make the server grumpy and refuse to run.

Doesn't have to be done within the hooks, the information could be
transfered to some log file that taken care of by a consumer script
later on.  It's just a matter of making it easier for it.

njs> It's also not clear you want to do any CIA/commit mail/etc.
njs> directly from such a hook, because such hooks block the entire
njs> server while running.  (What if your mail server is down/loaded
njs> and sending the mail blocks for a while, etc....)

True.  I was thinking that subprocesses are good things, but they
could easily bogg down a system in really bad situations.

Cheers,
Richard

-----
Please consider sponsoring my work on free software.
See http://www.free.lp.se/sponsoring.html for details.

-- 
Richard Levitte                         address@hidden
                                        http://richard.levitte.org/

"When I became a man I put away childish things, including
 the fear of childishness and the desire to be very grown up."
                                                -- C.S. Lewis