[Monotone-devel] review of .heights

[Nathaniel Smith]

The new 'db check' stuff looks good -- but there aren't any tests for
it!  Does it even work?  (In the past we've written tests for db check
stuff by having the test intentionally corrupt the db using 'db
execute', and then run db check and made sure the output was
sensible.)

On the same note, it occurs to me that rev_height.cc could really use
some unit tests to make sure that all those methods actually do what
they advertise.  Not necessarily a show-stopper.

In rev_height.cc, it would probably be better to define a dump()
overload than the debug dumping code you have here -- that way rev
heights would work with the existing MM() infrastructure.  Again, not
a show-stopper.

-- Nathaniel

-- 
Details are all that matters; God dwells there, and you never get to
see Him if you don't struggle to get them right. -- Stephen Jay Gould