monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] Error running `mtn list ignored` in monotone 0.32 o


From: Nathaniel J. Smith
Subject: Re: [Monotone-devel] Error running `mtn list ignored` in monotone 0.32 on windows XP
Date: Fri, 2 Feb 2007 15:30:06 -0800
User-agent: Mutt/1.2.5.1i

On Fri, Feb 02, 2007 at 09:53:44PM +0100, Christian Ohler wrote:
> When walk_tree_recursive calls bookkeeping_path::is_bookkeeping_path to 
> avoid descending into _MTN, the normalization in 
> bookkeeping_path::is_bookkeeping_path prepends the current working 
> directory to the path; the resulting (bogus) path no longer starts with 
> _MTN and is therefore not detected as a bookkeeping path.

Oh, ah-_hah_, of _course_ that's the problem.  There's a reason we
distinguish between "external" and "internal" paths, all old code
expected is_bookkeeping_path to take an "internal" path string, but
then when a call was added to args_to_paths that passed an "external"
path string, and is_bookkeeping_path was changed to match.

-- Nathaniel




reply via email to

[Prev in Thread] Current Thread [Next in Thread]