[Monotone-devel] Fw: [Monotone-commits-diffs] Revision ae23960b9b86036c738051292b52c223ad729aa1

[Richard Levitte]

Hello,

it seems like Visual C doesn't quite like a construct in pcrewrap.cc,
which I can understand would be a bit unexpected:

    if (startptr != string::const_iterator((char *)0))
      startoffset = &*startptr - &*subject.data();

The first of those two lines makes Visual C barf as thus:

    9>..\pcrewrap.cc(120) : error C2440: '<function-style-cast>' : cannot 
convert from 'char *' to 'std::_String_const_iterator<_Elem,_Traits,_Alloc>'

In the previous incarnation, before I added '(char *)', Visual C
complained that it couldn't convert 'int', otherwise the error message
was the same.

Any Windows guru willing to help figure it out?  I'm stumped!

Cheers,
Richard

-----
Please consider sponsoring my work on free software.
See http://www.free.lp.se/sponsoring.html for details.

-- 
Richard Levitte                         address@hidden
                                        http://richard.levitte.org/

"When I became a man I put away childish things, including
 the fear of childishness and the desire to be very grown up."
                                                -- C.S. Lewis

--- Begin Message --- Subject: [Monotone-commits-diffs] Revision ae23960b9b86036c738051292b52c223ad729aa1 Date: Sat, 10 Nov 2007 22:12:22 +0100

-----------------------------------------------------------------
Revision: ae23960b9b86036c738051292b52c223ad729aa1
Ancestor: 8600395cbe972d7bf48d2fe71cc36646099cb25b
Author: Richard Levitte <address@hidden>
Date: 2007-11-10T20:42:32
Branch: net.venge.monotone

Modified files:
        pcrewrap.cc

ChangeLog: 

        * pcrewrap.cc: It seems like Visual C does not understand that
        'string::const_iterator(0)' doesn't mean it should convert from
        integer, and honestly, I'm not sure it should, so let's be a bit
        explicit and see if that makes it better.

txt6fC6WcsTku.txt
Description: Diff [8600395cbe972d7bf48d2fe71cc36646099cb25b] -> [ae23960b9b86036c738051292b52c223ad729aa1]

_______________________________________________
Monotone-commits-diffs mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/monotone-commits-diffs

--- End Message ---