[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Fw: [Monotone-commits-diffs] Revision ae23960b9b860
|
From: |
Zack Weinberg |
|
Subject: |
Re: [Monotone-devel] Fw: [Monotone-commits-diffs] Revision ae23960b9b86036c738051292b52c223ad729aa1 |
|
Date: |
Sat, 10 Nov 2007 14:58:58 -0800 |
On Nov 10, 2007 1:24 PM, Zack Weinberg <address@hidden> wrote:
> On Nov 10, 2007 1:17 PM, Richard Levitte <address@hidden> wrote:
> > it seems like Visual C doesn't quite like a construct in pcrewrap.cc,
> > which I can understand would be a bit unexpected:
> >
> > if (startptr != string::const_iterator((char *)0))
> > startoffset = &*startptr - &*subject.data();
>
> [...] I think nothing uses startptr/startoffset, maybe it should just go.
> I'll look into that.
Sure enough. 954b7eb2034cc1c30ed968f935f433631ef925ed removes this entire mess.
zw