Re: [Monotone-devel] speed of "mtn ls branches"

[Richard Levitte]

In message <address@hidden> on Thu, 17 Jan 2008 19:40:09 +1100, William Uther 
<address@hidden> said:

willu.mailingLists> # patch "cmd_list.cc"
willu.mailingLists> #  from [bd12d9df9a26a4fc189681a3a374a211357ab9d2]
willu.mailingLists> #    to [d776611e29b3a5f1b99fb0d67c4a0e12895dfa5d]
willu.mailingLists> #
willu.mailingLists> ============================================================
willu.mailingLists> --- cmd_list.cc bd12d9df9a26a4fc189681a3a374a211357ab9d2
willu.mailingLists> +++ cmd_list.cc d776611e29b3a5f1b99fb0d67c4a0e12895dfa5d
willu.mailingLists> @@ -281,7 +281,7 @@ CMD(branches, "branches", "", CMD_REF(li
willu.mailingLists> 
willu.mailingLists>     globish exc(app.opts.exclude_patterns);
willu.mailingLists>     set<branch_name> names;
willu.mailingLists> -  app.get_project().get_branch_list(inc, names);
willu.mailingLists> +  app.get_project().get_branch_list(inc, names, 
!app.opts.ignore_suspend_certs);
willu.mailingLists> 
willu.mailingLists>     for (set<branch_name>::const_iterator i = names.begin();
willu.mailingLists>          i != names.end(); ++i)
willu.mailingLists> 
willu.mailingLists> I'm not sure if that should be committed or not.
willu.mailingLists> It reduces 'time ls branches
willu.mailingLists> --ignore-suspend-certs' on my monotone db from 7s
willu.mailingLists> down to less than 0.1s.  But it means ignoring the
willu.mailingLists> validity of certs in this case.
willu.mailingLists> 
willu.mailingLists> Thoughts?

If the user is explicitely asking for the suspend certs to be ignored,
why should we not allow it, especially since --ignore-suspend-certs is
a global option?

Cheers,
Richard

-----
Please consider sponsoring my work on free software.
See http://www.free.lp.se/sponsoring.html for details.

-- 
Richard Levitte                         address@hidden
                                        http://richard.levitte.org/

"When I became a man I put away childish things, including
 the fear of childishness and the desire to be very grown up."
                                                -- C.S. Lewis