Re: [Monotone-devel] Merging branch to allow duplicate key names, have certs use key hash

[Thomas Keller]

Timothy Brownawell schrieb:
>> 6) What about the hooks `get_branch_key` and `get_netsync_key`? Is it
>> allowed now these hooks return a local name or key ID or do we still
>> assume the given_name here?
> 
> What they return is treated the same as a key given on the command line
> -- it's tried as a key_id first, and if it's not [[:xdigit:]]{40} then
> it's tried as a local name and then a given name.
> 
>> 7) Should the format of read-permissions / write-permissions be extended
>> to allow listing of key ids / local names as well? I found no hints in
>> the branch's monotone.texi that anything has been changed there...
> 
> Those entries are tried first as key_id's, then as local names. They're
> not tried as given key names, since that seems a bit dangerous.

I think it would be a good idea to exactly describe this additionally in
the monotone docs, both for read/write permissions and the two hooks.

> Again, thanks for the review.

Thanks for your work! I'll have a deeper look at your other changes
tonight, currently on the run - weekend shopping :-/

Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

signature.asc
Description: OpenPGP digital signature