Re: [Monotone-devel] merging branch to allow 'automate stdio' over the network

[Stephen Leake]

Timothy Brownawell <address@hidden> writes:

> Stephen Leake wrote:
>> 
>> The documentation says the hook get_remote_automate_permitted returns
>> false for everything by default. However, I don't see the default
>> implementation anywhere; it's not in std_hooks.lua.
>
> There is no default hook defined, and it's set so that this has the same
> effect as having a hook that always returns false.

Ah. I didn't realize you could do that. It might be nice to have the
default implementation as an actual hook, so people can copy it to
modify it. But I guess the documentation in monotone.info is adequate
for that.

>>> How are network timeouts handled, i.e. do we automatically reconnect
>>> an idled but broken remote_stdio connection? 
>> 
>> See netsync.cc call_server; it uses E for a timeout, so it just
>> aborts.
>> 
>> In some applications, we want an automate session to tolerate long
>> idle times; it's waiting for a user to request something. When
>> connected remotely, I think it's ok to not tolerate that. Especially
>> for an ssh: connection, which ties up the remote database exclusively.
>> 
>> If the application wants to tolerate long user times, it should be
>> prepared to recreate the automate session on its own, rather than
>> relying on keeping an idle one open.
>> 
>> This should be mentioned in the info manual.
>
> This should be documented now.

Yes, that looks good.

-- 
-- Stephe