monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Monotone-devel] Fwd: monotone win32 socketpair


From: Thomas Keller
Subject: [Monotone-devel] Fwd: monotone win32 socketpair
Date: Thu, 18 Mar 2010 09:44:49 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.1.8) Gecko/20100228 SUSE/3.0.3-1.1.1 Lightning/1.0b2pre Thunderbird/3.0.3

Hi!

Could a windows developer check and eventually incorporate this new code
into monotone if its still there?
From what I've seen we already set the option in question in
netxx/socketopt.cxx (set_reuse_address), which is called from
Netxx::ServerBase::bind_to().

Thanks in advance,
Thomas.

-------- Original-Nachricht --------
Betreff: monotone win32 socketpair
Datum: Wed, 17 Mar 2010 22:07:34 -0700
Von: Nathan Myers <address@hidden>
An: address@hidden

Hi Thomas,

I was given to understand that a snippet of code I wrote
was incorporated into Monotone by Matthew Gregan back in 2007.
It implemented a selectable socketpair on win32, something
lacking in MS's posix compatibility library.

I have a new version of this socketpair now maintained at

  http://github.com/ncm/selectable-socketpair

It differs from the previous version in many cosmetic details,
but substantially in that it avoids a sort of resource leak by
setting the SO_REUSEADDR option on the listening socket it
creates.  You might want to make the same change in the version
of socketpair used in Monotone, if indeed the code is still there.

Nathan Myers
address@hidden

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]