|
From: | Mike Miller |
Subject: | [Octave-bug-tracker] [bug #45816] canonicalize_file_name() changed behavior between 3.8.2 and 4.0.0 on windows |
Date: | Thu, 03 Sep 2015 20:30:34 +0000 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Firefox/38.0 |
Follow-up Comment #21, bug #45816 (project octave): My own 2ยข: I think the include should be moved to the top, easy to search on the same conditional showing up twice in the file rather than needing to keep it with the conditional code. Many other parts of our baseline do it that way. My reading of the code for filesep is that it should be a forward slash ("/") on cygwin. I also see that filesep has an "all" option to return multiple separators where it's ambiguous. This should be a string containing both forward and backward slashes, on *both* native Windows and cygwin environments. So I think the recommendation would be for functions that need to parse path strings to use filesep("all") as the delimiter (see the fileparts.m function file). I'll copy this to the dependent bug as well for the geometry package. _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?45816> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |