|
From: | Carlo de Falco |
Subject: | [Octave-bug-tracker] [bug #53258] test pcg.m fail |
Date: | Thu, 8 Mar 2018 19:25:10 -0500 (EST) |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0) Gecko/20100101 Firefox/58.0 |
Follow-up Comment #16, bug #53258 (project octave): I went back to pcg in the default branch to hgid 2d68dc548561 (just before your change) and ran again for i = 1: 10_000; test pcg; endfor and got failure 57 times, this means approximately 1/175 of the runs are failing. Tried again with Cristiano's version and got 0 failures. My guess is that there might be a bug in the pcg implementation in the default branch that hinders convergence rate and your changes to the tests are just hiding it. My suggestion is to either revert this change and let the tests fail to make the bug apparent or to just move over to Cristiano's implementation that seems to have fixed this issue. Does that make sense? _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?53258> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |