|
From: | Rik |
Subject: | [Octave-bug-tracker] [bug #54405] octave_idx_type index integer overflow math check doesn't work correctly |
Date: | Tue, 31 Jul 2018 13:32:20 -0400 (EDT) |
User-agent: | Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0 |
Update of bug #54405 (project octave): Status: None => Ready For Test _______________________________________________________ Follow-up Comment #10: I think it is worthwhile to put the check for overflow within the get_size routine so that anyone that calls it (fread, sscanf) can get the benefit rather than just fread. Also, there is no need to call return after a call to the execption-based error function. See this cset https://hg.savannah.gnu.org/hgweb/octave/rev/39fd627b2c5d. It might be nice to have some BIST tests in io.tst for these exception conditions like using Inf, NaN, or large index sizes. Marking as "Ready for Test". _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?54405> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |