[Octave-bug-tracker] [bug #54405] octave_idx_type index integer overflow math check doesn't work correctly

[Dan Sebald]

Follow-up Comment #20, bug #54405 (project octave):

Ah, I'm looking at the changeset that Rik pushed:

http://hg.savannah.gnu.org/hgweb/octave/rev/39fd627b2c5d

and I do believe that is what the bots are seeing.  That get_size is used in
some try-catch blocks to the error doesn't throw and lingers, showing up in
strange places.  I think that is a pre-existing bug of its own.

In any case, the overflow check I proposed wasn't fully tested.  It's
incomplete regarding the -2^63 value.  (The compiler doesn't like that number
because it can't take the absolute value of it.)  Plus, I found that GNULIB
already has such a check using hardware-level features we can utilize.  So,
have a look at my recent changeset.  Maybe it's best to revert changeset
39fd627b2c5d and apply the new changeset, then address the try-catch thing, or
vice-versa.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?54405>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/