|
From: | Dan Sebald |
Subject: | [Octave-bug-tracker] [bug #54405] octave_idx_type index integer overflow math check doesn't work correctly |
Date: | Tue, 31 Jul 2018 22:13:16 -0400 (EDT) |
User-agent: | Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0 |
Follow-up Comment #24, bug #54405 (project octave): @Rik, There's probably some type of compiler flag different for your build that affect how try/catch behaves... My point from Comment #15 is that I don't think the overflow test can be moved inside of get_size() because that is only getting the two values and has no knowledge of how the sizes will be used. That is, so long as no multiplication of NR * NC is done, there can be valid cases where NR < INT_MAX and NC < INT_MAX, but not necessarily NR * NC < INT_MAX. _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?54405> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |