[Octave-bug-tracker] [bug #54405] octave_idx_type index integer overflow math check doesn't work correctly

[Rik]

Follow-up Comment #22, bug #54405 (project octave):

There are too many threads going on here.

First, the changeset I pushed is only about checking for an overflow in a
dimension or overall number of elements.

Second, it is not addressing the fact that there can be aliasing when a
dimension, represented as a double, is larger than 2^53 and converted in to a
uint64 type.  That is something separate.

Third, this can't be right


!!!!! known bug: https://octave.org/testfailure/?54405
expected error <negative>
but got <value on right hand side of assignment is undefined>
warning: test: file /home/sebald/matlab/octave/octave/test/io.tst leaked
global variables: __assert_printf__
PASSES 158 out of 159 tests (1 known bug)


because there are only 157 tests in io.tst and no mention of 54405.  Dan, I
think your repository is running with your own patch applied from comment #12
which is not what the buildbots are running.

Fourth, there is some strangeness in zeros, but it should be reported as a
different bug.  Test code for that would be


octave:1> zeros (1e64)
ans = [](0x0)
octave:2> zeros (1e63, 1e1)
error: out of memory or dimension too large for Octave's index type





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?54405>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/