[Octave-bug-tracker] [bug #55391] readline function 'operate-and-get-next' (Ctrl+o) crashes GUI

[Rik]

Follow-up Comment #1, bug #55391 (project octave):

Possibly related, static analysis reported a number of questionable practices
in the readline interface in Octave.


oct-rl-edit.c (201)
        V575    The potential null pointer is passed into 'strcpy' function. 
Inspect
the first argument. Check lines: 201, 201.
oct-rl-edit.c (293)
        V575    The potential null pointer is passed into 'strcpy' function. 
Inspect
the first argument. Check lines: 293, 293.
oct-rl-edit.c (301)
        V575    The potential null pointer is passed into 'strcpy' function. 
Inspect
the first argument. Check lines: 301, 301.
oct-rl-edit.c (321)
        V575    The potential null pointer is passed into 'strcpy' function. 
Inspect
the first argument. Check lines: 321, 321.
oct-rl-edit.c (329)
        V575    The potential null pointer is passed into 'strcpy' function. 
Inspect
the first argument. Check lines: 329, 329.
oct-rl-edit.c (337)
        V575    The potential null pointer is passed into 'strcpy' function. 
Inspect
the first argument. Check lines: 337, 337.
oct-rl-edit.c (435)
        V575    The potential null pointer is passed into 'strcpy' function. 
Inspect
the first argument. Check lines: 435, 435.
oct-rl-hist.c (61)
        V526    The 'strcmp' function returns 0 if corresponding strings are 
equal.
Consider examining the condition for mistakes.
oct-rl-hist.c (279)
        V1028   Possible overflow. Consider casting operands of the 'end - beg 
+ 1'
operator to the 'size_t' type, not the result.
oct-rl-hist.c (289)
        V575    The potential null pointer is passed into 'sprintf' function. 
Inspect
the first argument. Check lines: 289, 286.
oct-rl-hist.c (294)
        V522    There might be dereferencing of a potential null pointer 
'retval'.
Check lines: 294, 279.


Maybe it is worth correcting some of these to see if that fixes the problem. 
See bug #55347.

Or this may be entirely GUI specific and how shortcuts are handled there.

Were you in the Command Window or the Editor when you had the crash?

Also, what is the value of Preferences->Shortcuts->Disable global shortcuts
when Command Window has focus?  

The help text says that this option is specifically for avoiding trouble
between readline and the GUI.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55391>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/