[Octave-bug-tracker] [bug #55268] macos: images fail to build for docs

[Rik]

Follow-up Comment #37, bug #55268 (project octave):

@Pantxo: I think it is okay to push to stable.  The idea right now is to find
errors in the build system with RC1 and fix them which this certainly does.

Does this have any negative consequences for non-Mac users?  It appears that
this change is made for all operating systems.  One possibility if we are
concerned about limiting any potential side effects would be to use an
#ifdef/#end around the code which is Mac specific.  I compiled on a Linux
system and 'make check' passes so I suppose that is a small level of testing. 
I don't know about Windows.

This is just a small observation, but it is often easier to understand the
code if it can be read directly from top to bottom.  If there branches in
control flow then it is best practice to put the branch which is taken most
often first so that reading continues easily.  In the current code, the rare
case ("visible" == "off") is listed first and when following normal execution
one has to search for the else clause.  Also, the local variables "pos" and
"dpr" are only necessary in one of the branches of code.  Instead of declaring
them above the if statement, I would move them in to the block that is
Mac-specific since that is the smallest enclosing scope.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55268>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/